Repository navigation
Break the shared_ptr cycle between PavingNode parents and children - #484
Merged
Merged
Conversation
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddressSanitizer (LeakSanitizer) signalait des fuites dans les pavages : un
PavingNodepossède ses fils (_left,_right) et gardait aussi son parent parshared_ptr, si bien que chaque parent et ses fils se possédaient mutuellement ; une fois lePavingdétruit, aucun nœud d'un arbre bissecté n'était libéré. Le parent est maintenant tenu par unweak_ptr.L'arbre est aussi construit par les constructeurs de
PavingOutetPavingInOut(init_tree()) plutôt que par celui dePaving, où*static_cast<P*>(this)désignait unPpas encore construit. Des commentaires l'expliquent dans le code, et un test de non-régression est ajouté danscodac2_tests_CtcInverse.cpp.PR 12/64 de la série
dev-clean-v2(ordre et dépendances : #471). Indépendante : basée directement surcodac2, elle peut être mergée à tout moment.