Repository navigation
fix(core-ts): entryPath accepts the old one-argument call again - #79
Merged
Merged
Conversation
0.3.11 replaced the renderer's `entryPath(entry)` with core's `entryPath(site, entry)` under the same exported name. Themes copied from the starter before then (cloudhal.com, try, Deploy-button sites) call `entryPath(e)` in `EntryList.astro`; the call threw, Astro had already started streaming, and every page with an entry list answered 200 with an empty body. cloudhal.com was rolled back to its 0.3.10 build. `entryPath` now also takes the old form — one argument, or a `map` index second — and returns `/<collection>/<slug>` (deprecated overload). Verified on a site with the old theme copy: the home page renders again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
The 30-day deleted-entry rule measures from the deletion snapshot, which the store stamps with the real clock, while the test's `now` was a fixed T0 + 40 days. Once the calendar reached 2026-10-22 the gap was no longer 30 days and the test failed on main too. `now` is now 40 days after the later of T0 and the real time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Urgent. cloudhal.com served blank pages after updating to 0.3.12.
Cause
0.3.11 (RFC-0038 step 1, #72) replaced the renderer's exported
entryPath(entry)with core'sentryPath(site, entry)under the same name. Theme copies made before then (src/components/EntryList.astroin cloudhal.com, try and every Deploy-button site) still callentryPath(e). With one argument the call threw "Cannot read properties of undefined (reading 'collection')". Astro had already started streaming, so every page with an entry list answered 200 with an empty body.The tests didn't catch it because they only render the current starter, which was updated in the same PR.
Fix
entryPathhas a deprecated overload again: one argument, or amapindex as the second (entries.map(entryPath)), returns/<collection>/<slug>. Pass the site to get collection permalinks.Verified
permalinks.test.tshas a new case for both old call forms./returned 51 bytes; after, 185 kB with correct entry links.Already done
cloudhal.com's site Worker was rolled back to its 0.3.10 build (
wrangler rollback) and the cache was purged; Studio stays on 0.3.12.Follow-ups
EntryListto pass the site, so they get permalinks.🤖 Generated with Claude Code