Repository navigation
test: quiet the known log noise - #161
Merged
Merged
Conversation
Kumo's Badge resolves the dot colour from the variant, and the dot table only knows none, success, warning, error and neutral: every `<Badge variant="secondary" appearance="dot">` logged '[kumo] Unknown variant "secondary" … Falling back to "none"' (36 lines per CI run, from new-site.test.tsx) and rendered no dot at all. The five places that showed an unpublished site or an unknown scheduler state with a secondary dot now use neutral, Kumo's informational dot, so the dot appears and the warning goes away. No other dot Badge uses a variant outside that table (checked every literal and every variant map). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One of the test-log noise sources from the security/quality sweep, fixed where it is a one-word change: Kumo's
Badgeresolves the dot colour fromvariant, and the dot table only knowsnone,success,warning,errorandneutral. Every<Badge variant="secondary" appearance="dot">therefore logged[kumo] Unknown variant "secondary". Expected one of: none, success, warning, error, neutral. Falling back to "none".(36 lines in the last green CI run, all fromtest/new-site.test.tsx) and rendered no dot at all. Five places showed an unpublished site or an unknown scheduler state that way:apps/studio/src/routes/SitesPage.tsx,routes/ProjectPage.tsx,components/site-overview/SiteStatusCard.tsx: "Not published" badge,apps/studio/src/routes/SchedulesPage.tsx,components/ScheduleSettings.tsx: scheduler stateunknown.They now use
neutral(Kumo: "Neutral dot for informational status"), so the dot shows and the warning is gone. Every other dot Badge (literals and the*_VARIANT/*_BADGEmaps in Studio andpackages/ui) already uses a value from that table.The other noise sources (Better Auth's
Failed to validate API keyerror log from negative tests, the nested<button>hydration warnings in three screens,useRouteroutside aRouterProviderin the language-settings tests, happy-dom's iframe DOMException inpackages/ui) are not one-liners and are listed with a proposed fix each in the sweep report.Checked locally:
pnpm design:linton the five files,pnpm typecheckfor Studio, andtest/new-site.test.tsx,test/schedules-screens.test.tsx,test/collections-studio.test.tsx,test/design-rules.test.ts(601 tests, noUnknown variantline left in the output).Checklist
pnpm checkandcargo test --workspaceare left to CI (one machine, several sessions)@cloudhal/cli, but a missing status dot does not warrant a release note (no changeset)git commit -s, DCO)🤖 Generated with Claude Code