Repository navigation
fix(cli): give a local Chrome 30 s to start - #16
Merged
Merged
Conversation
A cold Chrome on a busy GitHub runner took over 10 s and failed the render tests with "Chrome did not start" (seen on #14 and the contributor-setup workflow) while warm starts stay under a second. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <asker_17@msn.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Merged
Madraka
added a commit
that referenced
this pull request
Oct 20, 2026
fix(cli): give a local Chrome 30 s to start
Madraka
added a commit
that referenced
this pull request
Nov 11, 2026
…ard (PR #205 review) - A (#5, #3, #6, #7): the definitions and collections anchors read the fragment's stored text when planned (checked against the planned Site, else ConflictError) and compare that text at batch time, so a site row stored verbatim anchors like any other. The canonical-rows job and its local-open run are removed: nothing depends on canonical site rows. - B (#2, #4): in a site with reference fields every entry write carries the definitions anchor (status-only publishes included); the shared subquery only matches reference and repeater definitions, so a retyped key fails the batch. - C (#0): usable members are one json_each count over the needed collection lists (six parameters, per-pair semantics kept). - D (#8, #15): the list-values fingerprint format moves to 2, so rows built under the old readsOriginal rebuild once. - E (#16): a referrer write naming an entry outside the field's collections is unknown_entry (422); reference_target_moved stays the move's 409. - F (#12): a reference sub-field added over a key stored items hold is field_key_in_use, counted and guarded on the site CAS. - G (#1): racing cases for the R3 narrowing in both orders, R13 for a move and a group change, the #2 interleaving, a verbatim site row, 22 blocking pairs, and SQL tests of the shared subquery. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The render tests intermittently failed on GitHub runners with
Error: Chrome did not start: on #14's Node 24 job and in the contributor-setup workflow. In both cases the test failed at exactly 10 s, the Chrome start timeout. A cold Chrome on a busy runner can take longer; a warm start stays under a second. The timeout is now 30 s, well inside the tests' own 60–90 s limits.render-chrome.test.tspasses locally (3/3)🤖 Generated with Claude Code