Repository navigation
feat(studio): Ended (collection rule) badge (#113) - #128
Merged
Merged
Conversation
A Kumo Badge inside a button that opens its reason as a Tooltip on hover, keyboard focus and a press, so a tap explains it on touch screens where a tooltip alone never opens. The reason is repeated in the accessible name; every word is a prop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
A published entry whose collection's expiry has passed shows "Ended (collection rule)" beside its status in the collection list and the entry editor header (RFC-0042 §3.3). It uses the site's derivedGate and entryVisibility, so Studio and the site agree; drafts, embargoed entries and entries whose own "Hide after" passed get no badge, and a translation reads its original's date only while the original is published. The toggletip names the field, the instant in the site's zone and what the site does (unlist or hide). The badge and its words load only for collections with an expiry. Closes #113 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #113. A published entry whose collection's expiry has passed now shows Ended (collection rule) beside its status, in the collection list and in the entry editor header (RFC-0042 §3.3). Before this, such an entry looked plainly published while the site had already left it out of lists, or answered "not found".
endedByRule(apps/studio/src/components/listings/ended-rule.ts) uses the samederivedGate/entryVisibilityas the site, so Studio and the site agree. The end is exclusive.@cloudhal/uiblock,ToggletipBadge: asecondarybadge with a 14 pxCalendarXicon inside a button.unlistorhide).listingswords load only for collections that have an expiry (lazy chunk).Verification (local)
ended-collection-rule.test.tsxadds 18: unlist/hide, draft, embargo, own "Hide after", exclusive end, grace, translation with a published or draft original, list and editor, toggletip by keyboard and press.@cloudhal/uiblock tests pass.pnpm design:lint, the typechecks,pnpm size:check,pnpm driftand the Studio build (bundle 391.0 kB of 420 kB).eventscollection (expiryunlistonendsOn) at 1440 and 390 px, plus pseudo-RTL:Review needed
listings.ended.badgeis "Sona erdi (koleksiyon kuralı)", and the reason text uses "… zamanında". Turkish is marked reviewed, so please check this wording. The other languages are AI drafts awaiting review, as usual.Checklist
pnpm checkandcargo test --workspacepass locally. The Studio and UI suites, design lint, typecheck, size check and drift were run piece by piece; there are no Rust changes. CI runs the full set.params.tswas regenerated withpnpm genand committed..changeset/studio-ended-collection-rule.md(@cloudhal/clipatch, Studio ships in the CLI)git commit -s, DCO)🤖 Generated with Claude Code