You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[go-migration] Some framework configurations cannot be customized with JBP_CONFIG_<FRAMEWORK> after overlay mechanism removal #1161
In the go-based buildpack The config/*.yml configuration files and the configuration overlay mechanism are now removed.
Functionalities for configuring with JBP_CONFIG_<FRAMEWORK> are available in the respective frameworks where parsing and handling of custom config properties is applied.
Some of the go-based frameworks though seem to lack possibility to adjust some of their corresponding configurations through JBP_CONFIG mechanism, for example:
google stack profiler framework - application_name and application_version properties which were set with priority from configuration as can be seen here are only obtained from VCAP_APLICATION in the go-based framework and custom config is not taken into concern.
java_memory_assistant framework - Some of the agent section properties that are with empty default values in the original config seem to be disregarded from possibly setting custom config values with JBP_CONFIG_JAVA_MEMORY_ASSISTANT in the go-based framework. For example if an app is staged with the following: JBP_CONFIG_JAVA_MEMORY_ASSISTANT: '{ enabled: true, agent: { thresholds: { heap: 1000 } } }' the threshold value won't be reflected in agent config. On this place and this place some values and custom values are not taken into concern. Also no java-memory-assistant cannot be downloaded at all with the go-based buildpack because corresponding info missing in manifest.yml.
jprofiler - Default values for enablednowait and port cannot be changed through JBP_CONFIG in the go-based buildpack framework
jrebel agent framework - setting enabled though JBP_CONFIG like in the current implementation seems not an option in the go-based framework. JBP_CONFIG_JREBEL_AGENT: '{ enabled: false }' won't disable jrebel. Enablement is based solely on having rebel-remote.xml.
apectj weaver agent - setting enabled though JBP_CONFIG like in the current implementation seems not an option in the go-based framework. JBP_CONFIG_ASPECTJ_WEAVER_AGENT: '{ enabled: false }' won't disable apectj weaver agent.
Activity