Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 7d81927 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
ben-reitz
force-pushed
the
browser/exec-options
branch
from
November 3, 2026 16:07
bd64b22 to
94bb5a3
Compare
ben-reitz
changed the base branch from
browser/browser-module
to
browser/exec-tool-metadata
November 4, 2026 10:44
The tool sets spread the exec tool's options across three top-level
keys: `exec` for the backend map, `execOutput` for output limits, and
`execMetadata` for run metadata. `exec` now takes them all as
`ExecToolSetOptions`, `{ backends, output, metadata }`, exported from
`@cloudflare/computer/tools`, and `execOutput` and `execMetadata` are
gone.
This breaks callers of the old form. A backend map moves under
`backends`, and `execOutput` becomes `exec.output`. A caller that
passed `exec: {}` to turn the tool off passes `exec: { backends: {} }`
instead. Read as the new form, both old shapes would quietly offer
every backend, so resolving the options throws a `TypeError` for an
`exec` with a key other than `backends`, `output`, and `metadata`,
and for `exec: {}`. The deprecated `shell` option still works, and
any `exec` still wins over it.
The docs, the package README, and the celld and mcp examples use the
new form.
ben-reitz
force-pushed
the
browser/exec-options
branch
from
November 4, 2026 10:55
b960f05 to
7d81927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tool sets spread the
exectool's options across three top-level keys:execfor the backend map,execOutputfor output limits, andexecMetadatafor run metadata, which #292 added. Review on #292 suggested grouping them underexec.execnow takes{ backends, output, metadata }, typed asExecToolSetOptionsand exported from@cloudflare/computer/tools.execOutputandexecMetadataare gone.This is a breaking change. To upgrade:
Read as the new form, an old backend map or
exec: {}would quietly offer every backend, so both throw aTypeErrorthat says what to pass instead. The deprecatedshelloption still works, and anyexecstill wins over it.The tests cover the new form,
execwithoutbackendsoffering every backend,exec: { backends: {} }turning the tool off, and the two old shapes throwing.docs/09_tool_interface.md,docs/17_isolate_javascript.md, the package README, and the celld and mcp examples use the new form.