Skip to content

Use const instead of let where applicable - #59

Closed
danbev wants to merge 1 commit into
cloudevents:masterfrom
danbev:use-const-instead-of-let
Closed

danbev wants to merge 1 commit into
cloudevents:masterfrom
danbev:use-const-instead-of-let

Conversation

@danbev

@danbev danbev commented Apr 21, 2020

Copy link
Copy Markdown
Contributor

Signed-off-by: Daniel Bevenius daniel.bevenius@gmail.com

Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
@lance

lance commented Apr 21, 2020

Copy link
Copy Markdown
Member

@danbev just FYI, most if not all of these changes are captured in #55

@danbev

danbev commented Apr 22, 2020

Copy link
Copy Markdown
Contributor Author

@lance I'll double check these changes once #55 lands and close this pr if everything is covered.

@grant

grant commented Apr 28, 2020

Copy link
Copy Markdown
Member

Looks like there are conflicts.

@fabiojose

Copy link
Copy Markdown
Contributor

@danbev fix the conflicts, please.

@danbev

danbev commented Apr 29, 2020

Copy link
Copy Markdown
Contributor Author

All of the these were taken care of by #55 so I'm closing this.

@danbev danbev closed this Apr 29, 2020
@danbev
danbev deleted the use-const-instead-of-let branch April 29, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants