Repository navigation
chore: release 5.3.2 - #470
Merged
Merged
Conversation
github-actions
Bot
force-pushed
the
release-v5.3.2
branch
from
February 11, 2022 04:26
507e592 to
b0ddf26
Compare
Member
|
Hi @lance, Are we ready to publish this package? This fixes #456 that fixes GoogleCloudPlatform/functions-framework-nodejs#425. |
Member
|
I would like for #471 to land first if possible. |
Member
grant
approved these changes
Feb 11, 2022
|
|
||
| ### Bug Fixes | ||
|
|
||
| * use `isolatedModules: true` in tsconfig.json ([#469](https://www.github.com/cloudevents/sdk-javascript/issues/469)) ([b5c0b56](https://www.github.com/cloudevents/sdk-javascript/commit/b5c0b56f52dd6119949df1a583b76a48c6e3cec7)) |
Member
There was a problem hiding this comment.
We shouldn't prevent a bug fix from being rolled out.
lance
approved these changes
Feb 11, 2022
Member
Member
|
Yes I am okay with it but cannot perform the release right now. If you need it for downstream, I don't want to stand in the way. I just am not able to do it myself at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release *beep* *boop*
5.3.2 (2022-02-11)
Bug Fixes
isolatedModules: truein tsconfig.json (#469) (b5c0b56)Miscellaneous
This PR was generated with Release Please.