Repository navigation
fix: use isolatedModules: true in tsconfig.json - #469
Merged
Merged
Conversation
This setting ensures the module can be used in projects where the workflow includes type checking and transpilation as two separate steps. See: https://ncjamieson.com/dont-export-const-enums/ Fixes: cloudevents#456 Signed-off-by: Lance Ball <lball@redhat.com>
grant
approved these changes
Feb 9, 2022
grant
left a comment
grant
left a comment
Member
There was a problem hiding this comment.
Formatting changes should be separate. Otherwise lgtm
Signed-off-by: Lance Ball <lball@redhat.com>
|
Thanks for jumping on this fix! Any idea when the next release will be? |
Member
Author
|
@lance sounds good 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This setting ensures the module can be used in projects where the workflow
includes type checking and transpilation as two separate steps.
See: https://ncjamieson.com/dont-export-const-enums/
Fixes: #456
Signed-off-by: Lance Ball lball@redhat.com