Skip to content

docs: add TS examples for CloudEvent usage - #461

Merged
lance merged 2 commits into
cloudevents:mainfrom
BOLT04:feat/198-add-ts-example
Jan 26, 2022
Merged

lance merged 2 commits into
cloudevents:mainfrom
BOLT04:feat/198-add-ts-example

Conversation

@BOLT04

@BOLT04 BOLT04 commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

Fixes: #198

Description

Added some examples of the CloudEvent class usage.
@lance the Event type doesn't seem to be exported in the latest cloudevents package, so I didn't add that example.

Do let me know if you want any more changes 👍

Signed-off-by: David <davidpereira2938@gmail.com>

@lance lance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BOLT04 thanks a lot for your contribution to the project. I just have one small wording nit, if you don't mind.

Comment thread README.md Resolved

@lholmquist lholmquist left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after that wording change

Co-authored-by: Lance Ball <lball@redhat.com>
Signed-off-by: David <davidpereira2938@gmail.com>
@BOLT04
BOLT04 force-pushed the feat/198-add-ts-example branch from b251bca to 3852c01 Compare January 26, 2022 19:42
@lance
lance merged commit c603831 into cloudevents:main Jan 26, 2022
@BOLT04
BOLT04 deleted the feat/198-add-ts-example branch January 27, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TypeScript example to README

3 participants