Repository navigation
chore: update cucumber dependency and remove prettier - #453
Merged
Merged
Conversation
The combination of prettier and eslint was causing some conflicting error messages in formatting between VSCode and using npm in the CLI. For the most part, there were only a couple of required formatting changes that prettier was covering, so the change is minor. The cucumber dependency had a major version bump and was carrying some unsafe dependencies in the older version. This commit bumps to the new version and makes appropriate configuration changes. Signed-off-by: Lance Ball <lball@redhat.com>
Member
Author
|
@grant @lholmquist can either of you take a quick look here? Thanks! |
grant
approved these changes
Dec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The combination of prettier and eslint was causing some conflicting error
messages in formatting between VSCode and using npm in the CLI. For the most
part, there were only a couple of required formatting changes that prettier
was covering, so the change is minor.
The cucumber dependency had a major version bump and was carrying some unsafe
dependencies in the older version. This commit bumps to the new version and
makes appropriate configuration changes.
Signed-off-by: Lance Ball lball@redhat.com