Repository navigation
feat: use generic type for CloudEvent data - #446
Merged
Merged
Conversation
Instead of using a big union of types, use a generic type for event data. Fixes: cloudevents#445 Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
Member
Author
|
@matthewrobertson thank you for the excellent feedback. I have incorporated your suggestions, but do have a couple of questions inline. |
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
|
LGTM |
Member
Author
|
@grant and @lholmquist - when you guys get a chance, a quick review here from one of you next week would be appreciated. Thanks! |
lholmquist
approved these changes
Nov 29, 2021
lholmquist
left a comment
lholmquist
left a comment
Contributor
There was a problem hiding this comment.
i needed to do a little reading up on TS generics, but LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using a big union of types, use a generic type for event data.
Fixes: #445
Signed-off-by: Lance Ball lball@redhat.com