Repository navigation
chore: use git submodules for conformance tests - #427
Merged
Merged
Conversation
I don't think downloading to `/tmp` for each `npm test` is such a great idea. This does mean that contributors to this repo will need to run the following command once on their clone after this commit lands. ``` git submodule init git submodule update ``` Signed-off-by: Lance Ball <lball@redhat.com>
lance
added
the
chore/refactor
lholmquist
approved these changes
Aug 5, 2021
lholmquist
left a comment
lholmquist
left a comment
Contributor
There was a problem hiding this comment.
I'm not usually a fan of submodules, but this case makes sense. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think downloading to
/tmpfor eachnpm testis such a greatidea. This does mean that contributors to this repo will need to run the
following command once on their clone after this commit lands.
Signed-off-by: Lance Ball lball@redhat.com