Repository navigation
backport(v3.2.x) onto the v3.x branch - #336
Merged
Merged
Conversation
* add ref to CoC and other things Signed-off-by: Doug Davis <dug@us.ibm.com>
Signed-off-by: Doug Davis <dug@us.ibm.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
This commit implements 4 of the 6 pending tests that were not completed
during the TypeScript rewrite. The two tests that were not implemented
were (one for each of v1 and v03):
```
it("returns a JSON string even if format is invalid");
```
I don't really know what that's supposed to be/mean, so I removed them.
Fixes: cloudevents#232
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
Snyk has created this PR to upgrade uuid from 8.2.0 to 8.3.0. See this package in npm: https://www.npmjs.com/package/uuid See this project in Snyk: https://app.snyk.io/org/lance/project/37afc620-45ad-41a3-9acc-1ac155caebc7?utm_source=github&utm_medium=upgrade-pr Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
* The commented out version import now gets imported from the cloudevent.ts file Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
… versions (cloudevents#321) * chore(readme): Remove reference of HTTPReceiver * chore(readme): fix support specification links. * This adds the real links to the v0.3 and v1.0 specification. fixes cloudevents#320 Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
…re (cloudevents#327) Signed-off-by: Lance Ball <lball@redhat.com>
…ces (cloudevents#324) * lib(messages): Implement a 4.0 Messages and other supporting interfaces This commit introduces the Message, Serializer and Deserializer, and Binding interfaces used to convert a CloudEvent into a Message that can be sent across a transport protocol. The first protocol implemented for this is HTTP, and some of the functionality formerly in src/transport/http has been simplified, reduced and/or moved to /src/messages/http. Test for V1 and V3 events are in place. Conformance tests have been modified to use these new interfaces vs. the HTTP Receiver class. Signed-off-by: Lance Ball <lball@redhat.com>
lance
added
module/releases
grant
approved these changes
Sep 3, 2020
Member
Author
|
Can't quite figure out why DCO check is failing. A visual scan of all commits shows them all as signed off. |
lholmquist
approved these changes
Sep 3, 2020
lholmquist
left a comment
lholmquist
left a comment
Contributor
There was a problem hiding this comment.
Once those other commits are added, then LGTM
Contributor
The check is complaing about this commit: |
Member
Author
|
@lholmquist I see it complaining about this one f3953a9. I just set that DCO check to pass manually, since a review of the commit message shows that it has been signed off. |
* feat: add a constructor parameter for loose validation This commit adds a second, optional boolean parameter to the `CloudEvent` constructor. When `false` is provided, the event constructor will not perform validation of the event properties, values and extension names. This commit also modifies the ValidationError class so that the error message string includes the JSON.stringified version of any schema validation errors. It also makes the HTTP.toEvent() function create CloudEvent objects with loose/no validation. Incorporates comments from cloudevents#328 Fixes: cloudevents#325 Signed-off-by: Lance Ball <lball@redhat.com>
Snyk has created this PR to upgrade cloudevents from 3.0.1 to 3.1.0. See this package in npm: https://www.npmjs.com/package/cloudevents See this project in Snyk: https://app.snyk.io/org/lance/project/cb2960b0-db0c-4e77-9ab2-e78efded812e?utm_source=github&utm_medium=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io> Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
…vents#334) Signed-off-by: Philip Hayes <phayes@redhat.com> Co-authored-by: Philip Hayes <phayes@redhat.com>
lance
force-pushed
the
v3.2.x-backport
branch
from
September 9, 2020 12:54
c351e34 to
5e50031
Compare
Member
Author
|
@cloudevents/sdk-javascript-maintainers I think we should be ready to drop a v3.2.0 release. GTG? |
Contributor
|
LGTM |
Contributor
|
@lance when you do merge this, don't hit "Squash and Merge" :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
We're landing breaking changes on
mainat the moment, so if we want to eventually do a 3.2.x release, we need to branch at f3953a9. We'll probably want to backport the following PR and commits before a release.feat: add a constructor parameter for loose validation #328
4779d89
7423acb
Version: Pending 3.2.0
❯ git log v3.x..v3.2.x-backport --onelined8df5ef (HEAD -> v3.2.x-backport, origin/v3.2.x-backport) chore(example): Replaced body parser with express JSON parser (#334)
719c2f0 fix: upgrade cloudevents from 3.0.1 to 3.1.0 (#335)
ae21dba feat: add a constructor parameter for loose validation (#328)
08e98c7 feat: introduce Message, Serializer, Deserializer and Binding interfaces (#324)
17d4bc8 chore: add cucumber.js to list of files to lint and /docs to .gitignore (#327)
73f0bec chore: Update README with correct links for the support specification versions (#321)
0adcc35 chore: Remove commented version import. (#319)
6e2390e fix: upgrade uuid from 8.2.0 to 8.3.0 (#317)
4bf2eb8 chore: Update references of master to main (#316)
b5cf886 test: implement pending tests leftover from TS rewrite (#315)
8ac3eb0 refactor: validate cloudevent version agnostic (#311)
81623ac chore: typo (#313)
b3624c2 docs: add ref to CoC and other things (#244)