Repository navigation
chore: fix promise tests to break the build when they fail - #305
Merged
lholmquist merged 4 commits intoAug 7, 2020
Merged
lholmquist merged 4 commits into
lholmquist merged 4 commits into
Conversation
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
lholmquist
force-pushed
the
303-promise-tests-not-failing-the-build
branch
from
August 6, 2020 15:23
7c1bf19 to
95b43ad
Compare
lholmquist
marked this pull request as ready for review
August 6, 2020 15:24
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates some the tests that are promise based to return the promise so mocha fails correctly if a test fails
Link to the CI run that proves that it fails, https://github.com/cloudevents/sdk-javascript/runs/954405480?check_suite_focus=true#step:6:559
Description