Repository navigation
fix: ensure that data encoded as base64 is parsed as an object - #285
Merged
Merged
Conversation
The 0.3 specification states that `datacontentencoding` may be set to base64. If an incoming event arrives over HTTP with this value set, and the content type is either application/json or application/cloudevents+json, then ensure that the data is decoded and parsed. Fixes: cloudevents#284 See: cloudevents#282 Signed-off-by: Lance Ball <lball@redhat.com>
lance
added
spec/0.3
lance
requested review from
danbev,
grant,
helio-frota and
lholmquist
and removed request for
a team
July 29, 2020 20:06
lholmquist
reviewed
Jul 29, 2020
Signed-off-by: Lance Ball <lball@redhat.com>
lholmquist
approved these changes
Jul 29, 2020
helio-frota
approved these changes
Jul 29, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Parse incoming data as JSON for an event with
datacontentencodingset to "base64"and a content type of application/json or application/cloudevents+json.
Description
The 0.3 specification states that
datacontentencodingmay be set to base64.If an incoming event arrives over HTTP with this value set, and the content type
is either application/json or application/cloudevents+json, then we should ensure
that the data is decoded and parsed, and the
datacontentencodingproperty isremoved.
Signed-off-by: Lance Ball lball@redhat.com