[grant]

Proposed Changes

• Simplify parsers
• Remove duplicate code
• Reduces file count/complexity over versioning

Description

• Fixes Issue Simplify Binary/Structured Receiver #273 (partially)

[lance]

This looks OK, but I'm trying to understand the benefit and where you have actually removed duplicate code. I see these three lines being consolidated by combining the two version files:

function parser(name: string, parser = new PassThroughParser()): MappedParser {
  return { name: name, parser: parser };
}

But I think that could addressed by moving that code into https://github.com/cloudevents/sdk-javascript/blob/master/src/parsers.ts and having both versions import it. They already have a dependency on the parsers file anyway. Personally, I prefer to have code for each version in a distinct file. Not sure how others feel about this.

[helio-frota]

@grant I'm not sure but my view on that is you are trying to "consolidate versions for the future" that approach is good so 👍 to that. So for what I understood when a new v.x spec come out, the project has the structure to add the things without much effort or something (?) also centralizing things in versions.ts ?

In other hand @lance's comment makes sense. So my question is your PR wording not accurate meaning or something ?

anyway I'm trying to get the point

[helio-frota]

I prefer to have code for each version in a distinct file. Not sure how others feel about this.

@lance I have no idea how many times and how often new versions will be created/added. The approach looks good to me but not sure about the benefit related with the occurrence of the future changes/additions in versions.

👍

[grant]

The PassThroughParser is not stateful and can be reused. It really should be static like I believe most every other function in this library.

Is there something you'd like me to change?

[lholmquist]

I don't have any strong feelings on keeping things separate. ATM, since there are only 2 versions, it probably doesn't matter combining them.

[lance]

Is there something you'd like me to change?

Not necessarily - was just trying to have some conversation around these questions.

[grant]

To be clear, I saw a lot of improvements beyond this, but I'd never finish a concrete PR if I went chasing them.