Repository navigation
refactor: combine v03 and v1 event interfaces, specs and schemas into single files - #270
Merged
lholmquist merged 3 commits intoJul 24, 2020
Merged
Conversation
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
lance
changed the title
lance
changed the title
lance
approved these changes
Jul 24, 2020
lance
added
the
chore/refactor
Closed
lholmquist
approved these changes
Jul 24, 2020
lholmquist
left a comment
lholmquist
left a comment
Contributor
There was a problem hiding this comment.
@grant if you can rebase this with master, then we can merge it in
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Member
Author
|
Pulled master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsplits v03 and v1 as there are lots of similarities between versions of CloudEvents. It's much nicer to edit one file with two edits than two files with one edit.
Does not change functionality.
Negative PR diffs are always good! We can probably combine the interfaces at a later point too.