Skip to content

chore: consolidate HTTP parsers and header maps into single files - #267

Merged
lholmquist merged 2 commits into
cloudevents:masterfrom
grant:grant_version_files
Jul 24, 2020
Merged

chore: consolidate HTTP parsers and header maps into single files#267
lholmquist merged 2 commits into
cloudevents:masterfrom
grant:grant_version_files

Conversation

@grant

@grant grant commented Jul 23, 2020

Copy link
Copy Markdown
Member
  • Simplifies the imports/files and updates exports for HTTP version parsers.
    -Removes duplicate copy-pasted parser functions.

grant and others added 2 commits July 23, 2020 11:46
@grant
Merge pull request #1 from cloudevents/master
145775b 
Merge
@grant
feat: simplify http version parsers
23d3826 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant
grant requested a review from lance July 23, 2020 22:41
@grant grant self-assigned this Jul 23, 2020
@grant grant changed the title Simplify Version Parser Simplify Transport Version Parser Jul 23, 2020
@lance lance changed the title Simplify Transport Version Parser chore: consolidate HTTP parsers and header maps into single files Jul 24, 2020
@lance lance added the chore/refactor Refactoring and other non-functional changes to module code label Jul 24, 2020
@lance lance mentioned this pull request Jul 24, 2020
Closed
@lholmquist
lholmquist merged commit 45850e3 into cloudevents:master Jul 24, 2020
@grant
grant deleted the grant_version_files branch July 24, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lance lance lance approved these changes
@lholmquist lholmquist lholmquist approved these changes

Assignees

@grant grant

Labels

chore/refactor Refactoring and other non-functional changes to module code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grant @lance @lholmquist