[lance]

Fixes: #71

Items remaining

• use git submodule to pull in the features from cloudevents/spec
• investigate why time stamps are not identical
• investigate why datacontenttype is not identical
• validate event data

[helio-frota]

The conformance tests are passing which is great!
But I'm not following why conformance submodule directory needs to have a golang project inside:

13:50 $ tree conformance/
conformance/
├── cmd
│   └── cloudevents
│       └── main.go
├── features
│   ├── http-protocol-binding.feature
│   └── kafka-protocol-binding.feature
├── go.mod
├── go.sum
├── hack
│   └── presubmit-test.sh
├── LICENSE
├── pkg
│   ├── commands
│   │   ├── commands.go

I'm guess that is because the (updated / common used) conformance spec is there.
If yes, maybe it can be downloaded and / or use the online version ?

It works fine (package.json):

"conformance": "cucumber-js https://raw.githubusercontent.com/cloudevents/conformance/master/features/http-protocol-binding.feature -p default",

13:51 $ npm run conformance

> cloudevents-sdk@2.0.2 conformance /home/hf/code/cloudevents/sdk-javascript
> cucumber-js https://raw.githubusercontent.com/cloudevents/conformance/master/features/http-protocol-binding.feature -p default

@http
Feature: HTTP protocol binding

  @http
  Scenario Outline: Binary content mode (application/json)
    Given HTTP Protocol Binding is supported
    Given an HTTP request
      """
      POST /someresource HTTP/1.1
...

[lance]

@helio-frota that's a good suggestion. I didn't realize you could provide a URL. Definitely better than pulling in a submodule

[lance]

@helio-frota I have not been able to make your suggestion work. Unclear why. 🤷‍♂️

[helio-frota]

@lance that was a false positive : ( the submodule was here, and when running pointing to a remote file, the cucumber falls back to the local file in the disk. Sorry.

But to try to remedy that I have created a small package called downtotemp and you can try using this way:

"conformance": "npx downtotemp https://raw.githubusercontent.com/cloudevents/conformance/master/features/http-protocol-binding.feature && cucumber-js /tmp/http-protocol-binding.feature -p default",

It is working least.

[lance]

@cloudevents/sdk-javascript-maintainers PTAL

@helio-frota thanks for the suggestions - done.

[lance]

Ping @cloudevents/sdk-javascript-maintainers ptal

[lholmquist]

What is the reasoning for moving the tests to an integration directory? Will the move mess with the merging of #233 since those tests are being updated there?

[lance]

@lholmquist it's mainly to keep the integration tests separate from the conformance steps that are now in test/conformance. I'm not sure how much trouble that merge will be. I imagine it won't be a problem, but 🤷

[lholmquist]

Welp, LGTM then