Skip to content

chore: add genertated _bundles to gitignore - #227

Merged
lance merged 1 commit into
cloudevents:masterfrom
lholmquist:add__bundles_to_gitignore
Jun 17, 2020
Merged

lance merged 1 commit into
cloudevents:masterfrom
lholmquist:add__bundles_to_gitignore

Conversation

@lholmquist

Copy link
Copy Markdown
Contributor

the _bundles/ was not ignored

Signed-off-by: Lucas Holmquist lholmqui@redhat.com

@lance

lance commented Jun 17, 2020

Copy link
Copy Markdown
Member

@lholmquist the reason this didn't get ignored is because I wanted to change it to /bundles and did so in .gitignore, but forgot to change it in webpack.config.js. Would you mind modifying this PR to actually change the output directory to bundles?

@lholmquist

Copy link
Copy Markdown
Contributor Author

ah, sure

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist
lholmquist force-pushed the add__bundles_to_gitignore branch from 58cac50 to b5f6fc2 Compare June 17, 2020 17:11
@lholmquist

Copy link
Copy Markdown
Contributor Author

updated

@lance lance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@lance
lance merged commit 7012433 into cloudevents:master Jun 17, 2020
@lance lance mentioned this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants