Skip to content

chore: adds the return type for the extension methods - #221

Merged
lance merged 1 commit into
cloudevents:masterfrom
lholmquist:add-return-types-for-extensions
Jun 18, 2020
Merged

lance merged 1 commit into
cloudevents:masterfrom
lholmquist:add-return-types-for-extensions

Conversation

@lholmquist

Copy link
Copy Markdown
Contributor

I'm usually a sublime text users, so i didn't catch this until i opened the code in vscode, but this adds the return types to the extension methods

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist
lholmquist force-pushed the add-return-types-for-extensions branch from 79623b8 to fc407cb Compare June 11, 2020 15:50
@lholmquist lholmquist changed the title chore: adds the return type for the extensions chore: adds the return type for the extension methods Jun 11, 2020

@lance lance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@lance lance added the type/fix A change that fixes something that is broken label Jun 18, 2020
@lance
lance merged commit 5ab8164 into cloudevents:master Jun 18, 2020
@lance lance mentioned this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/fix A change that fixes something that is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants