Skip to content

feat: ts formatter - #210

Merged
grant merged 1 commit into
masterfrom
ts
Jun 8, 2020
Merged

grant merged 1 commit into
masterfrom
ts

Conversation

@grant

@grant grant commented Jun 5, 2020

Copy link
Copy Markdown
Member

Uses any for now as many types are a bit whack with the hybrid ts/js repo.

@grant
grant requested a review from lance June 5, 2020 16:26
@grant grant self-assigned this Jun 5, 2020

@lance lance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you tried all of these suggestions and they didn't work - entirely possible.

Comment thread src/lib/formats/json/parser.ts Resolved
Comment thread src/lib/formats/json/formatter.ts Resolved
Comment thread src/lib/formats/json/parser.ts Resolved
@grant
grant force-pushed the ts branch 3 times, most recently from df98c3d to 2b0bd3a Compare June 6, 2020 19:14
@grant

grant commented Jun 6, 2020

Copy link
Copy Markdown
Member Author

DCO instructions are incorrect. :(

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>

@lance lance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grant
grant merged commit 90782a9 into master Jun 8, 2020
@grant
grant deleted the ts branch June 8, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants