Repository navigation
feat: introduce browser support - #201
Merged
Merged
Conversation
lance
added
type/enhancement
lance
requested review from
danbev,
fabiojose and
grant
and removed request for
a team
June 1, 2020 18:56
grant
approved these changes
Jun 1, 2020
Member
|
@lance probably package-lock needs to be pushed or something (?) I got this after npm install / npm run build: |
Member
Author
|
@helio-frota good catch - thanks! I've updated it. |
Member
|
@lance seems working
|
helio-frota
self-requested a review
June 3, 2020 20:55
helio-frota
approved these changes
Jun 3, 2020
Member
|
@lance seems these (some of) directories should be added to .gitignore ? |
Member
Author
Contributor
|
I got this warning about the webpack "mode" Maybe it should be set explicitly to avoid any changes in default behavior during a webpack version bump? |
This commit introduces a second `tsc` execution which generates JS in ES5 form. Then, webpack is used to generate a browser bundle. Signed-off-by: Lance Ball <lball@redhat.com>
lance
force-pushed
the
94-browser-support
branch
from
June 10, 2020 21:36
0823aec to
143f6a8
Compare
lance
marked this pull request as ready for review
June 10, 2020 21:36
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a second
tscexecution which generates JS in ES5 form.Then, webpack is used to generate a browser bundle.
Fixes: #94
WIP: Tests still pending.
Signed-off-by: Lance Ball lball@redhat.com