Skip to content

lib: make headerByGetter a Map - #171

Merged
lance merged 1 commit into
cloudevents:masterfrom
danbev:emitter-headermap
May 19, 2020
Merged

lance merged 1 commit into
cloudevents:masterfrom
danbev:emitter-headermap

Conversation

@danbev

@danbev danbev commented May 19, 2020

Copy link
Copy Markdown
Contributor

This commit turns the headerByGetter Object into a Map to reduces some
code duplication an hopefully improve readability a little.

Signed-off-by: Daniel Bevenius daniel.bevenius@gmail.com

This commit turns the headerByGetter Object into a Map to reduces some
code duplication an hopefully improve readability a little.

Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>

@lance lance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@lance
lance merged commit 57991e1 into cloudevents:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants