Repository navigation
Merged
Conversation
added 2 commits
June 11, 2019 14:48
Signed-off-by: Julia Huang <julia@playground.global>
Signed-off-by: Julia Huang <julia@playground.global>
ghost
mentioned this pull request
Contributor
|
@playground-julia Please check the CI, some tests are failing. |
Author
…ssing Signed-off-by: Julia Huang <julia@playground.global>
Author
|
@fabiojose tests are passing now. Copying comments from PR #14 over. I saw line 14. I don't think it's useless because the config object is being changed in line 6/7. That's what was causing npm test to fail... |
Contributor
|
@playground-julia Could you open an issue for registration and link this PR there? |
fabiojose
added
type/bug
Author
|
Issued and linked! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed content type and made optional parameters optional as detailed in the cloudevents spec.