Skip to content

chore: Modify CI to also build backport branch(es) - #122

Merged
lance merged 1 commit into
cloudevents:masterfrom
helio-frota:121-modify-ci
May 7, 2020
Merged

chore: Modify CI to also build backport branch(es)#122
lance merged 1 commit into
cloudevents:masterfrom
helio-frota:121-modify-ci

Conversation

@helio-frota

@helio-frota helio-frota commented May 5, 2020

Copy link
Copy Markdown
Member

Signed-off-by: Helio Frota 00hf11@gmail.com

@helio-frota
helio-frota requested a review from lance May 5, 2020 12:21
@helio-frota helio-frota mentioned this pull request May 5, 2020
Closed
lance
lance approved these changes May 5, 2020
View reviewed changes

@lance lance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@lance lance added chore/ci Changes to CI or the build version/1.x.backport Changes that should be backported to the 1.x release line status/stalled Issues that have not made progress recently labels May 5, 2020
@lance

lance commented May 6, 2020

Copy link
Copy Markdown
Member

Adding the label stalled here, as this may not be needed depending on the outcome of #85. We are currently planning a 2.0.0 release without plans for backporting anything to 1.0.0. Assuming a steady release cadence can be maintained, we may choose to support no prior versions once a new version is released. Stating here, for the record, I think that's a bad idea.

fabiojose
fabiojose approved these changes May 7, 2020
View reviewed changes

@fabiojose fabiojose left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance

lance commented May 7, 2020

Copy link
Copy Markdown
Member

@helio-frota do you mind changing this to just handle the lts issue and removing the build of backport branches? (but keep master and pull request builds active). Thanks!

@helio-frota
chore: Modify CI to also build backport branch(es)
6f52610 
Signed-off-by: Helio Frota <00hf11@gmail.com>
@lance
lance merged commit c1fda94 into cloudevents:master May 7, 2020
@helio-frota
helio-frota deleted the 121-modify-ci branch May 7, 2020 14:30
@helio-frota helio-frota self-assigned this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lance lance lance approved these changes
@fabiojose fabiojose fabiojose approved these changes

Assignees

@helio-frota helio-frota

Labels

chore/ci Changes to CI or the build status/stalled Issues that have not made progress recently version/1.x.backport Changes that should be backported to the 1.x release line

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@helio-frota @lance @fabiojose