HTTP headers name case for extensions #566

Activity

1. lholmquist commented on Sep 27, 2023

   

   lholmquist

   on Sep 27, 2023

   Contributor

   More actions

   I'm not following what the bug is here? do you have a reproducible example you could post?
2. Elvecent commented on Sep 28, 2023

   

   Elvecent

   on Sep 28, 2023

   Author

   More actions

   $ node
   Welcome to Node.js v20.5.0.
   Type ".help" for more information.
   > const { HTTP, httpTransport } = await import('cloudevents');
   undefined
   > const headers = {"Accept":"*/*","Ce-Id":"e2a8d1cb-7ef0-4efb-a24f-608c1715b196","Ce-Myext":"val","Ce-Source":"local","Ce-Specversion":"1.0","Ce-Type":"sometype","Content-Length":"82","Content-Type":"application/json","User-Agent":"curl/7.68.0"}
   undefined
   > HTTP.toEvent({ headers, body: "body"})
   Sanitized headers: {"accept":"*/*","ce-id":"e2a8d1cb-7ef0-4efb-a24f-608c1715b196","ce-myext":"val","ce-source":"local","ce-specversion":"1.0","ce-type":"sometype","content-length":"82","content-type":"application/json","user-agent":"curl/7.68.0"}
   Leftover sanitized headers: {"accept":"*/*","ce-myext":"val","content-length":"82","user-agent":"curl/7.68.0"}
   {"id":"e2a8d1cb-7ef0-4efb-a24f-608c1715b196","time":"2023-09-28T08:25:48.053Z","type":"sometype","source":"local","specversion":"1.0","datacontenttype":"application/json","data":"body"}
   

   Here, I expect that the resulting object contains value "val" at key "myext". Logs show the value of sanitizedHeaders, and I believe this is exactly where the .startsWith(__1.CONSTANTS.EXTENSIONS_PREFIX) check should happen, but instead it happens in headers, which is the original input headers in mixed case rather than lower case. So the "ce-" prefix check fails, because the actual prefix is "Ce-", and the extension is dropped.
3. github-actions commented on Oct 29, 2023

   

   github-actionsBot

   on Oct 29, 2023

   Contributor

   More actions

   This issue is stale because it has been open 30 days with no activity.
4. github-actions

   added

   status/no-issue-activity

   on Oct 29, 2023
5. duglin

   closed this as completedin #664on Nov 6, 2026
6. shiva

   added a commit that references this issue on Nov 6, 2026

   fix: read binary extension headers regardless of prefix case (cloudev…

   ...

   48b1745