Repository navigation
SHOULD update schema to latest CE-spec schema? #383
Description
Describe the Bug
The schemaV1 is currently not up to date with the one from the specification (e.g. spec schema contains source minLength 1, SDK schema doesn't). Therefore, event.validate() does for instance not throw when source is an empty string.
Steps to Reproduce
Use the following snippet:
const event = new CloudEvent({
id: '0815',
specversion: '1.0',
type: 'my.event.type',
source: '',
})
const validated = event.validate() // does not throw
console.log(validated) // trueExpected Behavior
Schema should be up to date so that event.validate() throws accordingly.
Additional context
Activity
github-actions commentedon Mar 14, 2021
This issue is stale because it has been open 30 days with no activity.
grant commentedon Sep 28, 2021
Yeah, it looks like we should add the check that properties that should be non-empty are in-fact non-empty.
Code change would be here:
https://github.com/cloudevents/sdk-javascript/blob/main/src/event/spec.ts
Not sure why
ajv.compiledoesn't validate the length here.fix: ensure source property has min length of 1
fix: ensure source property has min length of 1 (#438)