Typescript incompatible type in 3.1.0 and Express 4.x #340

Activity

1. lance commented on Sep 8, 2020

   

   lance

   on Sep 8, 2020

   Last edited by lance

   Member

   More actions

   It appears that the IncomingHttpHeaders type is from Node core, so I think this will probably be a common issue. We should consider modifying our type.

   sdk-javascript/src/message/index.ts

   Lines 21 to 23 in 1fa3a05

   	export interface Headers {
   	[key: string]: string;
   	}

   In the meantime @aabrams can you try

   const receivedEvent: CloudEvent = Receiver.accept(req.headers as Headers, req.body);
2. aabrams commented on Sep 9, 2020

   

   aabrams

   on Sep 9, 2020

   Author

   More actions

   Trying what you suggested (req.headers as Headers):

   Argument of type 'Headers' is not assignable to parameter of type 'import("c:/Users/adam_a/repos/Segment-Webhook/node_modules/cloudevents/dist/transport/http/headers").Headers'.
   Index signature is missing in type 'Headers'.ts(2345)
   Conversion of type 'IncomingHttpHeaders' to type 'Headers' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.ts(2352)
   Conversion of type 'IncomingHttpHeaders' to type 'Headers' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
   Type 'IncomingHttpHeaders' is missing the following properties from type 'Headers': append, delete, get, has, and 6 more.ts(2352)
3. lance

   added a commit that references this issue on Oct 1, 2020

   fix: extend Node.js IncomingHttpHeaders in our Headers type

   ...

   48f971e
4. lance

   closed this as completedin #346on Oct 6, 2020