Repository navigation
chore(example): Replaced body parser with express JSON parser - #334
Merged
Merged
Conversation
Signed-off-by: Philip Hayes <phayes@redhat.com>
lance
added
module/examples
lance
approved these changes
Sep 2, 2020
lance
left a comment
lance
left a comment
Member
There was a problem hiding this comment.
LGTM - thanks for the contribution @deewhyweb!
lholmquist
approved these changes
Sep 2, 2020
lholmquist
changed the title
lholmquist
pushed a commit
to lholmquist/sdk-javascript
that referenced
this pull request
Sep 8, 2020
…vents#334) Signed-off-by: Philip Hayes <phayes@redhat.com> Co-authored-by: Philip Hayes <phayes@redhat.com>
lance
pushed a commit
that referenced
this pull request
Sep 9, 2020
Signed-off-by: Philip Hayes <phayes@redhat.com> Co-authored-by: Philip Hayes <phayes@redhat.com>
lance
added a commit
to lance/sdk-javascript
that referenced
this pull request
Sep 9, 2020
* chore(example): Replaced body parser with express JSON parser (cloudevents#334) Signed-off-by: Philip Hayes <phayes@redhat.com> Co-authored-by: Philip Hayes <phayes@redhat.com> * fix: upgrade cloudevents from 3.0.1 to 3.1.0 (cloudevents#335) Snyk has created this PR to upgrade cloudevents from 3.0.1 to 3.1.0. See this package in npm: https://www.npmjs.com/package/cloudevents See this project in Snyk: https://app.snyk.io/org/lance/project/cb2960b0-db0c-4e77-9ab2-e78efded812e?utm_source=github&utm_medium=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io> Signed-off-by: Lucas Holmquist <lholmqui@redhat.com> * feat: add a constructor parameter for loose validation (cloudevents#328) * feat: add a constructor parameter for loose validation This commit adds a second, optional boolean parameter to the `CloudEvent` constructor. When `false` is provided, the event constructor will not perform validation of the event properties, values and extension names. This commit also modifies the ValidationError class so that the error message string includes the JSON.stringified version of any schema validation errors. It also makes the HTTP.toEvent() function create CloudEvent objects with loose/no validation. Incorporates comments from cloudevents#328 Fixes: cloudevents#325 Signed-off-by: Lance Ball <lball@redhat.com> Co-authored-by: Philip Hayes <philip@deewhy.ie> Co-authored-by: Philip Hayes <phayes@redhat.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Lance Ball <lball@redhat.com>
lance
pushed a commit
to lance/sdk-javascript
that referenced
this pull request
Sep 9, 2020
…vents#334) Signed-off-by: Philip Hayes <phayes@redhat.com> Co-authored-by: Philip Hayes <phayes@redhat.com>
lance
pushed a commit
that referenced
this pull request
Sep 11, 2020
Signed-off-by: Philip Hayes <phayes@redhat.com> Co-authored-by: Philip Hayes <phayes@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Replaces body parser with standard express body-parse module
Description