Repository navigation
refactor: validate cloudevent version agnostic - #311
Merged
Merged
Conversation
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Member
|
Looks good to me. But I don't understand how it "fixes" #273 really.
This PR doesn't really have any impact on the end user experience. So maybe you can clarify what you mean here. |
lholmquist
approved these changes
Aug 11, 2020
lholmquist
left a comment
lholmquist
left a comment
Contributor
There was a problem hiding this comment.
less code, less errors
but same question about how it relates to #273
Member
Author
lance
pushed a commit
that referenced
this pull request
Sep 11, 2020
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description