isCloudEvent Function #295

Activity

1. lance commented on Jul 31, 2020

   

   lance

   on Jul 31, 2020

   Last edited by lance

   Member

   More actions

   We do not have that in this module, although I can see it being useful. For a current project I am working on, we do this before trying to parse the event.

   https://github.com/boson-project/faas-js-runtime/blob/master/lib/event-handler.js#L32-L48
2. grant commented on Aug 11, 2020

   

   grant

   on Aug 11, 2020

   Last edited by grant

   MemberAuthor

   More actions

   @lance What do you think about this logic?

   https://github.com/cloudevents/sdk-javascript/blob/master/src/event/cloudevent.ts

   • static CloudEvent#isBinary
     • True if HTTP request has 4 required CE headers, otherwise false
3. lance commented on Aug 11, 2020

   

   lance

   on Aug 11, 2020

   Member

   More actions

   Hmm - I don't think that it makes sense for a static isBinary method on CloudEvent because a CloudEvent itself is neither binary or structured. Those are just transport representations and really only make sense in the context of an incoming request over a transport protocol.

   This would make more sense as a standalone function in cloudevents/transport/http. The logic for an isCloudEvent (distinct from isBinary) method should be something like this:

   • if the content-type header is set to an event format media type return true (it's a structured event)
   • if the ce-id, ce-type, ce-source and ce-specversion headers exist return true (it's a binary event)
   • else return false
4. grant commented on Aug 11, 2020

   

   grant

   on Aug 11, 2020

   MemberAuthor

   More actions

   Yup, adding the method to the HTTP transport files instead of CloudEvent files makes sense.
5. lance

   added

   module/libRelated to the main source codeRelated to the main source code

   type/enhancementNew feature or requestNew feature or request

   on Aug 17, 2020
6. lance

   added a commit that references this issue on Aug 24, 2020

   src(message): adds Detector interface to ease detection of events

   ...

   02ad12c
7. lance

   closed this as completedin #324on Aug 26, 2020