Immutable event builder #29

Activity

1. lance commented on May 9, 2020

   

   lance

   on May 9, 2020

   Member

   More actions

   @fabiojose I agree that events should probably be immutable - aside from a well-defined path for converting from/to spec versions. Given how the repo has been evolving, how do you think this issue should progress?
2. lance

   added

   type/discussionIssues that need to be decided/debated/discussedIssues that need to be decided/debated/discussed

   type/enhancementNew feature or requestNew feature or request

   on May 9, 2020
3. grant commented on May 18, 2020

   

   grant

   on May 18, 2020

   Member

   More actions

   how do you think this issue should progress?

   If we use JSON for CloudEvents, then we can just Object.freeze our event data to make it immutable.

   Requires #65.
4. lance commented on May 29, 2020

   

   lance

   on May 29, 2020

   Member

   More actions

   I'm going to mark this a stalled for now. TypeScript users now have Object.freeze for regular objects. However, that doesn't work for the CloudEvent class. We'd need to add a freeze() method to the class itself to prevent modification. This is because the setters on the class delegate to this.spec.

   👍React with 👍1Reacted by Grant Timmerman
5. lance

   added

   status/stalledIssues that have not made progress recentlyIssues that have not made progress recently

   on May 29, 2020
6. github-actions commented on Jun 29, 2020

   

   github-actionsBot

   on Jun 29, 2020

   Contributor

   More actions

   This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days
7. github-actions

   added

   status/no-issue-activity

   on Jun 29, 2020
8. grant commented on Jul 1, 2020

   

   grant

   on Jul 1, 2020

   Member

   More actions

   Marking all CloudEvent fields as readonly should be a solution.

   This is very common and recommended in TypeScript. See vscode's source for examples.
9. lance

   removed

   type/discussionIssues that need to be decided/debated/discussedIssues that need to be decided/debated/discussed

   on Jul 1, 2020
10. github-actions

    closed this as completedon Jul 3, 2020
11. lholmquist

    reopened this on Jul 3, 2020
12. lholmquist

    removed

    status/no-issue-activity

    status/stalledIssues that have not made progress recentlyIssues that have not made progress recently

    on Jul 3, 2020
13. lance commented on Jul 3, 2020

    

    lance

    on Jul 3, 2020

    Member

    More actions

    Weird that the bot closed this
14. lance commented on Jul 21, 2020

    

    lance

    on Jul 21, 2020

    Member

    More actions

    While not exposed via an actual builder, I think #234 should satisfy this issue. Closing.
15. lance

    closed this as completedon Jul 21, 2020