Repository navigation
Browser Version of the module is still called cloudevents-sdk #286
Description
Describe the Bug
The name of the module changed in #260, but the webpack config was never updated, https://github.com/cloudevents/sdk-javascript/blob/master/webpack.config.js
Steps to Reproduce
- Create a Browser Application
- Bring in the cloudevents-sdk
window[cloudevents-sdk]exists
3a. Also, the cloudevents-sdk.js file exists in the built bundles folder
Expected Behavior
module name should be cloudevents
Additional context
Since the 3.0.0 release was just released, can we do this change without a major version bump? It is changing the name, so i think it has to be, but 3.x was just released, and the name was changed, so if we release a 3.0.2 soon, we might be able to get it in there without the major bump.
Activity
lance commentedon Jul 30, 2020
Agree - I think we can just consider this a bug and fix it and release a patch version
fix: update browser name to cloudevents.
fix: update browser name to cloudevents. (#292)