Skip to content

CloudEvent should only allow [^a-z|0-9$] for extension names #228

Closed

Description

@lance

Per the spec's naming conventions, attribute names should be all lower case, with nothing but a-z and 0-9 in the name. This module currently does not enforce that.

Activity

  1. added
    type/bugSomething isn't working
    spec/1.0Issues related to the CE specification
    on Jun 20, 2020
  2. self-assigned this
    on Jun 29, 2020
  3. lholmquist commented on Jul 6, 2020

    @lholmquist
    Contributor

    Is the "-" also allowed. reading the spec, it doesn't look like it. If that is the case, then we will need to update the examples

  4. lance commented on Jul 6, 2020

    @lance
    MemberAuthor

    It is not allowed. Only alphanumeric characters.

    CloudEvents attribute names MUST consist of lower-case letters ('a' to 'z') or digits ('0' to '9') from the ASCII character set. Attribute names SHOULD be descriptive and terse and SHOULD NOT exceed 20 characters in length.

    https://github.com/cloudevents/spec/blob/master/spec.md#attribute-naming-convention

  5. lholmquist commented on Jul 6, 2020

    @lholmquist
    Contributor

    Should we make this a semver-major change then?

  6. lance commented on Jul 7, 2020

    @lance
    MemberAuthor

    Should we make this a semver-major change then?

    Yes - we will have a semver major release as soon as the typescript version lands, so it should land with that.

  7. assigned and unassigned on Jul 7, 2020
  8. added
    version/3.xIssues related to the 3.0 release of this library
    on Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

spec/1.0Issues related to the CE specificationtype/bugSomething isn't workingversion/3.xIssues related to the 3.0 release of this library

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions