Repository navigation
Formatter should be static #195
Description
I noticed the formatter lives within the CloudEvent object.
CloudEvent {
spec:
Spec1 {
payload:
{ specversion: '1.0',
id: '1234',
time: '2020-05-28T20:46:18.970Z',
source: '/some/source',
type: 'example',
datacontenttype: undefined,
data: undefined,
subject: undefined } },
formatter: JSONFormatter {},
extensions: [] }This doesn't really make sense since we can have 1000 CloudEvent objects with the same formatter.
Maybe it should be a static class/set of methods.
Activity
lance commentedon May 29, 2020
I was thinking actually of removing it entirely from the class, along with the
format()function. Instead, expose a top levelFormatterclass orformatter()function that takes aCloudEventand formats it as JSON by default. But of course that would be a breaking change and require a version bump. Making it static is a good first step.lholmquist commentedon Jun 10, 2020
Somewhat related is the
toStringmethod. All this is doing is aJSON.stringify, which could just as easily be done without this method.Like the formatter, it would be a major version bump for removal though
lholmquist commentedon Jun 10, 2020
@lance @grant if either of you haven't started to work on this, i could take a look at breaking the Formatter into its own function
lance commentedon Jun 10, 2020
@lholmquist all yours
grant commentedon Jun 10, 2020
☝️ All yours.
lholmquist commentedon Jun 18, 2020
Probably going to hold off on this since it will be part of #226
should we close?