Skip to content

HTTP binding for binary format #18

New issue
New issue
Closed
Closed
HTTP binding for binary format#18
Labels
good first issueGood for newcomerstype/bugSomething isn't working

Description

@ghost
ghost
opened on Jun 11, 2019

The HTTP binding for binary formatted data currently does not follow the cloudevents/spec:

  1. The event type, time, and schema url should not be required
  2. the content-type should be json, but not cloudevents-json

Additionally, the config object should be copied because creating multiple bindings with the same config will override the content-type.

Fixed in issue #14.

Activity

  1. fabiojose
    added
    type/bugSomething isn't working
    good first issueGood for newcomers
    on Jun 12, 2019

  2. fabiojose commented on Jun 25, 2019

    @fabiojose
    fabiojose
    on Jun 25, 2019
    Contributor

    Release in version 0.2.2

  3. fabiojose
    closed this as completedon Jun 25, 2019

  5. fabiojose commented on Jun 30, 2019

    @fabiojose
    fabiojose
    on Jun 30, 2019
    Contributor

    Oh boy! I will check what gonna wrong!

  6. fabiojose
    added a commit that references this issue on Jun 30, 2019

    closes #18

    d1f2720

  7. fabiojose commented on Jun 30, 2019

    @fabiojose
    fabiojose
    on Jun 30, 2019
    Contributor

    Fixed! https://github.com/cloudevents/sdk-javascript/releases/tag/v0.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomerstype/bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions