Skip to content

Remove generated files from source control #175

Closed

Description

@grant

This PR #140 introduced 21,838 lines of mostly HTML/non-Cloud SDK code into master.

It introduces files not related to this repo:
https://github.com/cloudevents/sdk-javascript/tree/master/docs/fonts

For example, these files were not hand-written and aren't expected to be added to source control:
Screen Shot 2020-05-21 at 11 15 09

@lance can we use gh-pages instead for this or somehow not include these files in master? This is common for most projects and will keep PRs slim. Or let's just use md files rather than HTML files.

Activity

  1. grant commented on May 21, 2020

    @grant
    MemberAuthor

    A docs/ folder is simply not very node-like.

    Feel free to look at the way any of the top npm packages document their modules for comparison:
    https://www.npmjs.com/browse/depended

  2. grant commented on Jun 3, 2020

    @grant
    MemberAuthor

    This was fixed in #194.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions