You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CloudEvent should expose a method to get all of the CE headers #149
The SDK should provide a simpler way to extract all of the headers from a CE. Check with sdk-go to see if/how this is exposed there. I'm not 100% sure about exposing them on a CloudEvent directly since that binds it to the HTTP transport. But what happens when we implement AVRO for example?
In retrospect, it seems that adding this method directly to the CloudEvent class is perhaps not the best approach. That conflates the event itself with the HTTP transport protocol. I would like to keep these two concepts decoupled. I currently have an implementation for this on the HTTPEmitter which is introduced in this PR soon #141. Once that PR lands, I'll submit this change for consideration.
Activity
squash: add headers() to the HTTPEmitter function
lance commentedon May 14, 2020
In retrospect, it seems that adding this method directly to the
CloudEventclass is perhaps not the best approach. That conflates the event itself with the HTTP transport protocol. I would like to keep these two concepts decoupled. I currently have an implementation for this on theHTTPEmitterwhich is introduced in this PR soon #141. Once that PR lands, I'll submit this change for consideration.