Repository navigation
Suggestion of Node.js versions on CI based on package maintenance group practices #119
Description
Hi,
Based on recent comments here and here
I found that may be worth to open this issue.
Directly to the point, the idea is to avoid changing Node.js LTS versions over the time by using lts/* and able to include specific versions (current and/or deprecated) as can be seen here
Here is an article with information about that approach:
https://medium.com/@nodejs/choosing-the-node-js-versions-for-your-ci-tests-hint-use-lts-89b67f68d7ca
Activity
grant commentedon May 4, 2020
Adding
lts/*LGTM.lance commentedon May 4, 2020
I like that it will always pick up the most recent LTS version. However, it won't automatically get version 10, which means in
.travis.yamlwe'd still need to have both10andlts/*specified.It does buy us LTS testing the moment a new LTS version is released, which is nice. We'd just need to remember to add
12once14is released.helio-frota commentedon May 5, 2020
Yeah, still need to have 10. This is to remove the need of updating lts over time.
lance commentedon May 7, 2020
@helio-frota can you speak closed? It looks like #106 took care of it, right?
helio-frota commentedon May 7, 2020
@lance Sorry, I guess I'm not following your question.
The idea in this issue is just to change the hard-coded 12 to
lts/*in.travis.yml, all the other versions keep the same.lance commentedon May 7, 2020
@helio-frota OMG I'm sorry! I was making these comments while only half awake this morning using voice to text. It's a mess. I mean to say... would you mind updating #121 so that it doesn't build the backport branch, but keeps this suggested change?
helio-frota commentedon May 7, 2020
@lance yup not a problem, PR updated 👍
helio-frota commentedon May 7, 2020
Closing... PR landed c1fda94