This repository was archived by the owner on May 15, 2023. It is now read-only.
Repository navigation
Bump cachetools dependency version. - #84
Merged
Merged
Conversation
I analysed the changes between cachetools v1.1.6 and v2.1.0. There are no significant changes to the part of the library, which is referenced by endpoints-management-python library.
noirbee
added a commit
to lumapps/endpoints-management-python
that referenced
this pull request
Oct 25, 2019
Fixes incompatibility with some of the other google-cloud package, see also: - cloudendpoints#72 - cloudendpoints#84
|
Note that this change only allows for A better requirement would be |
|
👍 (nice catch @di) |
whitlockjc
approved these changes
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I analysed the changes between cachetools v1.1.6 and v2.1.0. There
are no significant changes to the part of the library, which is
referenced by endpoints-management-python library.
I guess the version pin was placed for cachetools because the requirement was added in Jul 2016, three months before the relase of cachetools 2.0.0. It could have been intended as a safeguard against braking changes, unknown at that time.
We can safely release a new minor version 1.11.1 of google-endpoints-api-management with requirements on cachetools relaxed. I tested the change by locally building the modified google-endpoints-api-management package and following Cloud Frameworks for Python tutorial using the following command to install packages:
pip install --target lib --ignore-installed --system --find-links=file://$HOME/repo/google-endpoints-api-management/ --requirement=requirements.txt
(i also modified tutorial's requirements.txt to use google-endpoints-api-management==1.11.1)