Skip to content
This repository was archived by the owner on May 15, 2023. It is now read-only.

Bump cachetools dependency version. - #84

Merged
tomboc merged 2 commits into
cloudendpoints:masterfrom
tomboc:master
Apr 14, 2020
Merged

tomboc merged 2 commits into
cloudendpoints:masterfrom
tomboc:master

Conversation

@tomboc

@tomboc tomboc commented Mar 15, 2019

Copy link
Copy Markdown
Contributor

I analysed the changes between cachetools v1.1.6 and v2.1.0. There
are no significant changes to the part of the library, which is
referenced by endpoints-management-python library.

I guess the version pin was placed for cachetools because the requirement was added in Jul 2016, three months before the relase of cachetools 2.0.0. It could have been intended as a safeguard against braking changes, unknown at that time.

We can safely release a new minor version 1.11.1 of google-endpoints-api-management with requirements on cachetools relaxed. I tested the change by locally building the modified google-endpoints-api-management package and following Cloud Frameworks for Python tutorial using the following command to install packages:
pip install --target lib --ignore-installed --system --find-links=file://$HOME/repo/google-endpoints-api-management/ --requirement=requirements.txt
(i also modified tutorial's requirements.txt to use google-endpoints-api-management==1.11.1)

I analysed the changes between cachetools v1.1.6 and v2.1.0. There
are no significant changes to the part of the library, which is
referenced by endpoints-management-python library.
noirbee added a commit to lumapps/endpoints-management-python that referenced this pull request Oct 25, 2019
Fixes incompatibility with some of the other google-cloud package, see also:
- cloudendpoints#72
- cloudendpoints#84
@di

di commented Mar 17, 2020

Copy link
Copy Markdown

Note that this change only allows for cachetools==2.0.0, not later 2.x versions:

>>> from packaging.specifiers import SpecifierSet
>>> SpecifierSet('>=1.0.0,<=2')
<SpecifierSet('<=2,>=1.0.0')>
>>> s = SpecifierSet('>=1.0.0,<=2')
>>> '2.0.0' in s
True
>>> '2.1.0' in s
False

A better requirement would be cachetools>=1.0.0,<3.

@whitlockjc

whitlockjc commented Apr 14, 2020 •

Copy link
Copy Markdown

👍 (nice catch @di)

@tomboc
tomboc merged commit f67427d into cloudendpoints:master Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants