You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
LogRecord::contextIsEmpty() returns true when the context is not empty #84
LogRecord::contextIsEmpty() returns true when the context is not empty ([] !== $this->context). The "Has context info ?" column of the logs CRUD, which uses it, is displayed correctly, but the method name says the opposite.
Tested on main (9032210, v3.0.1) in process-bundle-demo, PHP 8.5, Symfony 7.4, EasyAdmin 5.
Proposed fix
Add LogRecord::hasContext(), use it in LogRecordCrudController, and deprecate contextIsEmpty() (kept as is, for compatibility).
Requirements
Documentation updates
Reference
Changelog
Unit tests
Breaking changes
None: contextIsEmpty() is deprecated, its behaviour is unchanged.
Regression of the merged fix: hasContext() is used by the PropertyAccessor to read the context property (empty context on the log detail page). Fixed by renaming it hasContextInfo(), see the linked PR.
Activity
#83 #84 #85 Remove the broken UploadAndExecuteAction, add LogRecord::…
Merge pull request #86 from cleverage/83
njoubert-cleverage commentedon Oct 2, 2026
Regression of the merged fix:
hasContext()is used by the PropertyAccessor to read thecontextproperty (empty context on the log detail page). Fixed by renaming ithasContextInfo(), see the linked PR.Merge pull request #87 from cleverage/84-fix