Repository navigation
#422 - Tests: behaviors shown untested by the surviving mutants - #423
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #422
Tests only, no change of the code. Infection run again on the files of the ticket (
ProcessManager,ProcessConfiguration,xpath_evaluator,XmlFile,XmlStreamReaderTask,InputCsvReaderTask,InputFolderBrowserTask,LineReaderTask,cached): covered code MSI from 69 % to 82 % (escaped mutants from 189 to 114 of 640).ProcessManagerFlowTest(new), with recording tasks:skipstrategy (next tasks not executed for the item, default error output = input, error output set by the task), stop propagated through the parent tasks and from an error branch, previous state and its exception given to an error branch, context given to the tasks, flush after an iterable task (next tasks and error outputs, stopped at a blocking task), stop during the flush, empty iterable task, blocking task with and without input, process executed again after a failure.ProcessConfigurationTest(new): dependency groups topologically sorted on 30 random acyclic graphs (fixed seeds), main task group (entry point, else end point, else first task), cycle not sorted.xpath_evaluator:single_result/ignore_missing, too many results, subquery options, option types, libxml state restored (previous errors not reported, none left,libxml_use_internal_errors()restored).XmlFile,XmlStreamReaderTask: libxml state, warnings tolerated, exact (trimmed) messages, read twice, root element, directory rejected.InputCsvReaderTaskbase_path,InputFolderBrowserTaskbase_folder_path(options validated on initialization, another folder rejected while browsing),cachedttl(normalized, expiry, transformers applied once on a miss, save failure logged, non-string key),LineReaderTaskfilenametype.Remaining mutants are mostly equivalent: visibility, log messages and contexts, the
READ_AHEAD | SKIP_EMPTYflags ofLineReaderTask(no observable effect:SKIP_EMPTYonly works withDROP_NEW_LINE, empty lines are emitted, as already tested), and flush calls masked by the repeated flushes (below).Observed while writing the tests, not changed here (pinned only where it is guaranteed):
FlushableTaskInterfacetask is flushed several times: once its iterable parent has no more item, then again each time one of its ancestors or itself is resolved (resolve()flushes the subtree of each task); it is also flushed when it has never been executed (empty iterable parent), and after a stop during a flush;null);ProcessState::stop()without error does not flag the process as stopped (ProcessEvent::isProcessStopped()), only thestoptask does.🤖 Generated with Claude Code