Skip to content

#197 - Add missing tests - #245

Merged
njoubert-cleverage merged 1 commit into
mainfrom
197
Oct 9, 2026
Merged

njoubert-cleverage merged 1 commit into
mainfrom
197

Conversation

@njoubert-cleverage

Copy link
Copy Markdown
Member

Description

Fixes #197.

Every concrete Task and Transformer now has a unit test (#[CoversClass]): 48 new test files under tests/Task/ and tests/Transformer/, written with real collaborators (mocks only for ProcessManager and serializer pass-through checks). They cover nominal cases, every option, documented edge cases and error paths.

  • Tasks: ConstantOutputTask, ConstantIterableOutputTask, DummyTask, StopTask, SkipEmptyTask, FilterTask, PropertyGetterTask, ArrayMergeTask, AggregateIterableTask, GroupByAggregateIterableTask, InputAggregatorTask, InputIteratorTask, RowAggregatorTask, SplitJoinLineTask, TransformerTask, DebugTask, DieTask (run in a separate PHP process), ErrorForwarderTask, StopwatchTask, LoggerTask, ProcessExecutorTask, ValidatorTask, DenormalizerTask, CsvWriterTask, FileMoverTask, FileReaderTask, FileRemoverTask, FileWriterTask, InputFileReaderTask, JsonStreamReaderTask, XmlReaderTask, XmlWriterTask, YamlReaderTask, YamlWriterTask
  • Transformers: MappingTransformer, CallbackTransformer, ConvertValueTransformer, EvaluatorTransformer, UnsetTransformer, ArrayLastTransformer, ArrayMapTransformer, ArrayUnsetTransformer, InstantiateTransformer, PropertyAccessorTransformer, RecursivePropertySetterTransformer, NormalizeTransformer, DenormalizeTransformer, PregMatchTransformer

The relevant scenarios of the obsolete, kernel-based tests.old/ directory (not run by PHPUnit) were ported to these unit tests, and the directory is removed.

No change in src/. The bugs found while writing the tests are not asserted (their cases are left out) and are reported separately: #239, #240, #241, #242, #243, #244.

The suite goes from 249 to 799 tests. PHPUnit, PHPStan, PHP-CS-Fixer and Rector pass, and the new files are valid PHP 8.2. The 2 remaining PHPUnit deprecations come from phpunit.xml.dist itself (deprecated schema and executionOrder="depends") and already exist on main.

Requirements

  • Documentation updates
    • Reference
    • Cookbooks
    • Changelog
  • Unit tests

Breaking changes

None: tests only.

🤖 Generated with Claude Code

…d by unit tests. Remove the obsolete tests.old directory.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@njoubert-cleverage
njoubert-cleverage merged commit 5a9307e into main Oct 9, 2026
17 checks passed
@njoubert-cleverage
njoubert-cleverage deleted the 197 branch October 9, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing tests

1 participant