You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
A finalization failure does not make the process fail; process_launcher leaves its sub-processes running when the process fails #396
Two issues at the end of a process, now that the tasks are finalized when it fails (#373):
A finalization failure does not make the process fail: when finalize() throws on a process that has succeeded, the exception is logged as critical, the process history is flagged as failed and "Process … failed" is logged, but ProcessManager::execute() returns normally. The cleverage_process.end event is dispatched (the UI records the execution as finish), the command exits with 0, and a parent process (process_executor) goes on.
process_launcher leaves its sub-processes running: when the process fails or is stopped (stop request, StopTask) while sub-processes launched by process_launcher are still running, nothing stops them. They go on with their side effects after the end of the process, their error output is no longer read (risk of blocking on a full pipe), and their JSON buffers are left in the temporary directory.
Fix: once every task is finalized, throw a ProcessFailedException if a finalization has failed; make ProcessLauncherTask finalizable, to stop its running sub-processes and remove the buffers that will never be output.
Found during the audit v3 (audit-v3-angles.md#179, #180).
Activity
Merge pull request #397 from cleverage/396