Skip to content

process_launcher with json_buffering outputs the path of an empty buffer and leaves the buffers in the temporary directory #367

Closed

Description

@njoubert-cleverage

Regression of 5.5 (#343).

ProcessLauncherTask (process_launcher) with json_buffering: the JSON buffer is now created before the sub-process is launched (TemporaryFile::create() in SubprocessInstance), and SubprocessInstance::getResult() only checks that the file exists.

When the sub-process has no end_point, or when its output is not an array (nothing is written in the buffer by cleverage:process:execute), the task now outputs the path of an empty cdm_buffer_*.json-stream file for each launch. In 5.4.1 it output nothing, as documented in process_launcher_task.md and 04-advanced_workflow.md ("otherwise … the task outputs nothing"). A task reading the path directly receives unexpected inputs.

The buffer files are also never deleted: one file is left in the temporary directory for each launch, even when the output is empty or when the sub-process fails.

Fix: in getResult(), delete an empty buffer and return null; delete the buffer when the sub-process fails.

Found during the audit after the 5.5 release (audit-v4-post-release.md #214).

Activity

  1. added a commit that references this issue on Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions