You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
YamlWriterTask: a write failure is ignored, the path is output as if the file had been written #345
YamlWriterTask (yaml_writer) does not check the result of file_put_contents(). When the parent directory does not exist (or is not writable), PHP only raises a warning, which becomes an exception in debug mode only: in production, the task outputs the path as if the file had been written, and the next tasks work on a missing file.
It is also inconsistent with json_stream_writer and csv_writer, which create the parent directory.
Fix: create the parent directory if needed (as JsonStreamFile), and throw a RuntimeException when the file cannot be written.
Found during the global audit after the 5.4 release (process-bundle-audit.md#102).
Activity
Merge pull request #346 from cleverage/345