You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ProcessManager: the task configuration used by the logs is not restored after a child task or a sub-process #333
ProcessManager keeps the task being executed in $taskConfiguration, read by the Monolog processors to add task_code and task_service to the logs (also persisted by the UI bundle). It is set when a task starts and set to null when it ends, but never restored to the previous value:
After a child task (outputs) has been processed, $taskConfiguration is null while its parent iterable task goes on: from the 2nd iteration, the logs of the parent task have no task_code nor task_service.
After a sub-process (process_executor), the task of the sub-process (or null) stays: the error of a failed sub-process is logged in the parent with the task_code of the task of the sub-process.
The early returns of process() (stop, empty iterable) skip the reset to null.
#301 restores the process history ($processHistory) in the same situations, not the task configuration.
Fix: restore the previous task configuration when process(), initialize(), finalize() and execute() end, including on early returns and exceptions.
Found during the global audit after the 5.4 release (process-bundle-audit.md#81).
Activity
Merge pull request #334 from cleverage/333